| Conditions | 5 |
| Total Lines | 162 |
| Code Lines | 111 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | import { useState, useEffect } from 'react'; |
||
| 40 | |||
| 41 | export default function Map({navigation, API_KEY, position, setPosition, token}): any { |
||
| 42 | const [locationMarker, setLocationMarker] = useState(null); |
||
| 43 | const [currentCity, setCurrentCity] = useState(null); |
||
| 44 | const [zones, setZones] = useState([]); |
||
| 45 | const [scooters, setScooters] = useState([]); |
||
| 46 | const [currentScooter, setCurrentScooter] = useState(null); |
||
| 47 | const [modalVisible, setModalVisible] = useState(false); |
||
| 48 | const [zoneModalVisible, setZoneModalVisible] = useState(false); |
||
| 49 | const [currentZone, setCurrentZone] = useState(null); |
||
| 50 | const [cameraVisible, setCameraVisible] = useState(false); |
||
| 51 | const [journeyModal, setJourneyModal] = useState(false); |
||
| 52 | const [toggleTimer, setToggleTimer] = useState(false); |
||
| 53 | const [markerSelected, setMarkerSelected] = useState(null); |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Set user position |
||
| 57 | */ |
||
| 58 | useEffect(() => { |
||
| 59 | async function fetchPosition(): Promise<void> { |
||
| 60 | const { status } = await Location.requestForegroundPermissionsAsync(); |
||
| 61 | |||
| 62 | // if (status !== 'granted') { |
||
| 63 | // setErrorMessage('Permission to access location was denied'); |
||
| 64 | // return; |
||
| 65 | // } |
||
| 66 | |||
| 67 | const currentLocation = await Location.getCurrentPositionAsync({}); |
||
| 68 | |||
| 69 | const userCoordinates = { |
||
| 70 | //latlang hardcoded for testing |
||
| 71 | // latitude: currentLocation.coords.latitude, |
||
| 72 | // longitude: currentLocation.coords.longitude |
||
| 73 | latitude: 56.161013580817986, |
||
| 74 | longitude: 15.587742977884904 |
||
| 75 | }; |
||
| 76 | |||
| 77 | |||
| 78 | setPosition(userCoordinates); |
||
| 79 | |||
| 80 | mapModel.getClosestCity(position); |
||
| 81 | |||
| 82 | setLocationMarker(<Marker |
||
| 83 | coordinate={{ |
||
| 84 | //latlang hardcoded for testing |
||
| 85 | // latitude: currentLocation.coords.latitude, |
||
| 86 | // longitude: currentLocation.coords.longitude |
||
| 87 | latitude: 56.161013580817986, |
||
| 88 | longitude: 15.587742977884904 |
||
| 89 | }} |
||
| 90 | title="My location" |
||
| 91 | pinColor="blue" |
||
| 92 | flat={false} |
||
| 93 | />); |
||
| 94 | }; |
||
| 95 | |||
| 96 | |||
| 97 | fetchPosition(); |
||
| 98 | |||
| 99 | }, []); |
||
| 100 | |||
| 101 | /** |
||
| 102 | * Set city to city that is closest to user and zones for that city |
||
| 103 | */ |
||
| 104 | useEffect(() => { |
||
| 105 | async function setUpMap(): Promise<void> { |
||
| 106 | const city = await mapModel.getClosestCity(position); |
||
| 107 | |||
| 108 | |||
| 109 | // Set city that is closest to user |
||
| 110 | setCurrentCity(city); |
||
| 111 | |||
| 112 | /** |
||
| 113 | * Set zones on map |
||
| 114 | */ |
||
| 115 | const zones = mapModel.getZones(city); |
||
| 116 | setZones(zones); |
||
| 117 | |||
| 118 | |||
| 119 | /** |
||
| 120 | * Get all scooters and create markers for them on the map |
||
| 121 | */ |
||
| 122 | const result = await scooterModel.getScooters(API_KEY, city); |
||
| 123 | |||
| 124 | const scooters = result['cityScooters']; |
||
| 125 | const sortedScooters = scooterModel.sortAvailableScooters(scooters); |
||
| 126 | // console.log(scooters[0]); |
||
| 127 | |||
| 128 | // console.log(sortedScooters[0]); |
||
| 129 | |||
| 130 | setScooters(sortedScooters); |
||
| 131 | |||
| 132 | }; |
||
| 133 | setUpMap(); |
||
| 134 | }, []); |
||
| 135 | |||
| 136 | |||
| 137 | return ( |
||
| 138 | <View style={styles.container}> |
||
| 139 | <MapView |
||
| 140 | style={styles.map} |
||
| 141 | region={{ |
||
| 142 | latitude: position.latitude? position.latitude : 0, |
||
| 143 | longitude: position.longitude? position.longitude : 0, |
||
| 144 | latitudeDelta: 0.03, |
||
| 145 | longitudeDelta: 0.03, |
||
| 146 | }} |
||
| 147 | userInterfaceStyle={'dark'} |
||
| 148 | > |
||
| 149 | {locationMarker} |
||
| 150 | |||
| 151 | {scooters.map((s, index) => |
||
| 152 | <Marker |
||
| 153 | // title={s['name']} |
||
| 154 | // description={`Charge ${s['battery']}% ${s['status']}`} |
||
| 155 | coordinate={s['coordinates']} |
||
| 156 | icon={markerIcon(index, markerSelected)} |
||
| 157 | tappable={true} |
||
| 158 | key={index} |
||
| 159 | onPress={() => { |
||
| 160 | setCurrentScooter(s); |
||
| 161 | setModalVisible(true); |
||
| 162 | setMarkerSelected(index); |
||
| 163 | }} |
||
| 164 | > |
||
| 165 | </Marker> |
||
| 166 | )} |
||
| 167 | {zones.map((z, index) => ( |
||
| 168 | <Polygon |
||
| 169 | coordinates={z['coordinates']} |
||
| 170 | strokeColor={z['zoneColor']} |
||
| 171 | strokeWidth={3} |
||
| 172 | fillColor={z['zoneColor']} |
||
| 173 | key={index} |
||
| 174 | tappable={true} |
||
| 175 | onPress={() => { |
||
| 176 | setCurrentZone(z) |
||
| 177 | setZoneModalVisible(true) |
||
| 178 | }} |
||
| 179 | /> |
||
| 180 | ))} |
||
| 181 | </MapView> |
||
| 182 | |||
| 183 | <ScooterModal navigation={navigation} scooter={currentScooter} modalVisible={modalVisible} currentCity={currentCity} setModalVisible={setModalVisible} setJourneyModal={setJourneyModal} setToggleTimer={setToggleTimer}/> |
||
| 184 | |||
| 185 | <ZoneModal navigation={navigation} zone={currentZone} zoneModalVisible={zoneModalVisible} setZoneModalVisible={setZoneModalVisible} /> |
||
| 186 | |||
| 187 | |||
| 188 | <JourneyModal navigation={navigation} scooter={currentScooter} journeyModal={journeyModal} setJourneyModal={setJourneyModal} toggleTimer={toggleTimer} setToggleTimer={setToggleTimer}/> |
||
| 189 | |||
| 190 | <Pressable onPress={() => {setCameraVisible(true)}} style={styles.googleLogin}> |
||
| 191 | <Icon |
||
| 192 | name='screen-full' |
||
| 193 | size={15} |
||
| 194 | color='white' |
||
| 195 | /> |
||
| 196 | <Text style={styles.googleText}>Scan to unlock</Text> |
||
| 197 | </Pressable> |
||
| 198 | |||
| 199 | <NavBar navigation={navigation} /> |
||
| 200 | <QrScanner navigation={navigation} cameraVisible={cameraVisible} setCameraVisible={setCameraVisible}/> |
||
| 201 | </View> |
||
| 202 | |||
| 264 |